Skip to content

[5.9][AST] Use a different operator for member attribute macros #65980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

[5.9][AST] Use a different operator for member attribute macros #65980

merged 1 commit into from
May 18, 2023

Conversation

bnbarham
Copy link
Contributor

  • Explanation: Mangled macro names are currently used as the name we write the expansion to on-disk. Having names that only differ in case-sensitivity then causes issues on case-insensitive file systems. Update the operator of member attributes so that it doesn't collide with accessor macros.
  • Scope: Macros
  • Risk: Very low - is just slightly adjusting member attribute mangling and we verify being able to demangle when retrieving the mangled name.
  • Testing: Updated existing tests that check for the mangled name.
  • Original PR: [AST] Use a different operator for member attribute macros #65963

@bnbarham
[AST] Use a different operator for member attribute macros
8a6d507 
Macro expansions are currently written to disk using the mangled name of
the macro. Do not use operators that only differ in case-sensitivity to
avoid issues on case-insensitive filesystems.

Resolves rdar://109371653.

(cherry picked from commit 515d22a)
@bnbarham bnbarham added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 17, 2023
@bnbarham bnbarham requested a review from a team as a code owner May 17, 2023 18:50
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit a42d778 into swiftlang:release/5.9 May 18, 2023
@bnbarham bnbarham deleted the cherry-change-member-attr-mangling branch May 18, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @DougGregor