[5.9] [Sema] Allow if/switch expressions in optional chain assignments #65920
+516
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we could miss the scopes present in if/switch expressions if they were nested in another expression, such as an AssignExpr. Fix the logic such that we properly walk over a given expression looking for if/switch scopes, the same as what we do for closures. rdar://109192116
Make sure we look through a wrapping `OptionalEvaluationExpr` and its injections when looking for an assignment to mark a valid if/switch source expression. rdar://109305454
hamishknight
added
🍒 release cherry pick
Contributor
Author
|
@swift-ci please test |
airspeedswift
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9 cherry-pick of #65915, based on #65905