[cxx-interop] implicitly imported CxxShim module should not force cli… #65875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
egorzhdan
reviewed
May 14, 2023
Contributor
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
Would libcxxstdlibshim.h also require a similar fix?
Contributor
Author
No, the compiler doesn't implicitly add it as an import when C++ interop is enabled. |
egorzhdan
reviewed
May 15, 2023
Contributor
There was a problem hiding this comment.
I think there is a less intrusive way to fix this: can we make the implicit import of CxxShim @_implementationOnly?
In Frontend.cpp:
if (Invocation.getLangOptions().EnableCXXInterop && canImportCxxShim()) {
pushImport(CXX_SHIM_NAME, {ImportFlags::ImplementationOnly});
}
That way IIUC the compiler would also refuse to compile such modules with cross-module optimization enabled instead of crashing.
Contributor
Author
|
Yes, I can try that. |
…ent modules to enable C++ interoperability Fixes swiftlang#65831
hyp
force-pushed
the
eng/impl-only-letsgoo
branch
from
b30b61a to
b17ade9
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@egorzhdan updated :) |
egorzhdan
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent modules to enable C++ interoperability
Fixes #65831