[Test] Avoid verifying SILGen in cursor info test #65809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifying SILGen causes `loadAllMembers` to be run, which in turn ends up actually creating the parent PBD of each `VarDecl` in this test. Without verification, we never deserialize that PBD and thus end up with `class` instead of `static` as we should. That's incorrect, but it's an existing failure (rdar://105239467). Resolves rdar://109037827.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@hamishknight is looking into fixing this properly (thanks!) |
This was referenced May 9, 2023
hamishknight
approved these changes
May 9, 2023
Contributor
Author
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying SILGen causes
loadAllMembersto be run, which in turn ends up actually creating the parent PBD of eachVarDeclin this test. Without verification, we never deserialize that PBD and thus end up withclassinstead ofstaticas we should. That's incorrect, but it's an existing failure (rdar://105239467).Resolves rdar://109037827.