[5.9][interop][SwiftToCxx] remove extraneous semicolon when emitting 'prag… #65752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma clang module import' The semicolon actually causes a compiler error in that case (cherry picked from commit 228078f)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test macOS platform |
DougGregor
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ma clang module import'
The semicolon actually causes a compiler error in that case
(cherry picked from commit 228078f)
Explanation: The emitted
#pragma clang module importdirective had a semicolon at the end of it which caused an error when this code was actually reached by the preprocessor. Remove the semicolon.Scope: Swift's and C++ interoperability, generated header printer.
Risk: Low. This only affects the use of
#pragma clang module importthat imports dependencies in C++ mode.Testing: Swift unit tests, manual testing on some adopter projects and several Swift packages that import C.
PR: #65662
Reviewer: @egorzhdan