[interop][SwiftToCxx] avoid emitting ambiguous C++ overloads and emit unavailable type stubs for top level types that could not be emitted in the C++ section of the generated header #65728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that could not be emitted in the C++ section of the generated header
hyp
requested review from
egorzhdan,
hborla,
slavapestov,
xedin and
zoecarver
as code owners
Contributor
Author
|
Needed follow ups:
|
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Just do an arity check for now
hyp
force-pushed
the
eng/safe-overloads-and-unavailable-unemitted-decls-in-cxx
branch
from
884909f to
c7836e3
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
…xx.swift test on Linux and Windows
hyp
force-pushed
the
eng/safe-overloads-and-unavailable-unemitted-decls-in-cxx
branch
from
c9c69fc to
4010357
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Swift's consume semantics are not yet supported in C++
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
…ate decls only emit them for public ones
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
zoecarver
reviewed
May 8, 2023
Contributor
zoecarver
left a comment
zoecarver
left a comment
There was a problem hiding this comment.
Not a super in depth review, but this look great to me! Super excited to see these UX improvements :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[interop][SwiftToCxx] emit unavailable type stubs for top level types that could not be emitted in the C++ section of the generated header
[interop][SwiftToCxx] avoid emitting ambiguous C++ overloads
Just do an arity check for now
[interop][SwiftToCxx] do not expose move-only Swift types