Skip to content

[5.9] [Macros] Fix lazy expansion of freestanding macros within types/extensions #65671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2023
Merged

[5.9] [Macros] Fix lazy expansion of freestanding macros within types/extensions #65671

merged 2 commits into from
May 5, 2023

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented May 4, 2023 •
edited
Loading

  • Explanation: An incorrectly-specified starting context for name lookup meant that macro lookup itself was failing, and therefore did not trigger expansion of the freestanding macro or introduction of the macro-expanded declarations into the context.
  • Scope: Narrow; affects code using freestanding declaration macros within types or extensions.
  • Risk: Low, no effect in code that doesn't use macros.
  • Review: @rxwei
  • Issue: rdar://108824784
  • Original pull request: [Macros] Fix lazy expansion of freestanding macros within types/extensions #65670

DougGregor added 2 commits May 4, 2023 12:28
@DougGregor
[Macros] Ensure imported macros work with top-level freestanding macros
db025ed
@DougGregor
[Macros] Fix lazy expansion of freestanding macros within types/exten…
2034b34 
…sions

An incorrectly-specified starting context for name lookup meant that
macro lookup itself was failing, and therefore did not trigger
expansion of the freestanding macro or introduction of the
macro-expanded declarations into the context.

Fixes rdar://108824784.
@DougGregor DougGregor requested a review from a team as a code owner May 4, 2023 19:30
@DougGregor
Copy link
Member Author

DougGregor commented May 4, 2023

@swift-ci please test

@DougGregor DougGregor merged commit db49a31 into swiftlang:release/5.9 May 5, 2023
@DougGregor DougGregor deleted the freestanding-member-lookup-5.9 branch May 5, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbkka tbkka tbkka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DougGregor @tbkka