[Executors] Make move to ExecutorJob binary compatible; deprecate Job #65455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-bincompat-job-rename
branch
from
59f3f16 to
95a93a9
Compare
Contributor
Author
|
@swift-ci please smoke test |
xedin
approved these changes
May 1, 2023
Contributor
xedin
left a comment
xedin
left a comment
There was a problem hiding this comment.
LGTM! Please format your changes with clang-format before merging.
Contributor
Author
|
rdar://108772378 |
This was referenced May 2, 2023
ktoso
force-pushed
the
wip-bincompat-job-rename
branch
2 times, most recently
from
5e85c62 to
9acc587
Compare
ktoso
force-pushed
the
wip-bincompat-job-rename
branch
from
9acc587 to
b847ee1
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #65038 we renamed Job to ExecutorJob and introduced a typealias. We knew this would be binary breaking however we hoped the change would not cause problems since noone had adopted this new API yet -- we were wrong.
This change introduces a binary compatible way to introduce
ExecutorJobwhile keepingJobas deprecated and hopefully we'd be able to remove it still.Diagnostics were adjusted to handle the new type and push developers towards the right implementation method.