Skip to content

[Concurrency] Re-enable test on iOS platform: enqueue impls #65225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Concurrency] Re-enable test on iOS platform: enqueue impls #65225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5eb2bc
[Concurrency] Re-enable test on iOS platform: enqueue impls
ktoso Apr 17, 2023
14e11b4
Merge branch 'main' into wip-reenable-test
ktoso May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/Concurrency/custom_executor_enqueue_impls.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
// RUN: %target-typecheck-verify-swift -enable-experimental-move-only -disable-availability-checking
// RUN: %target-typecheck-verify-swift -enable-experimental-move-only
// REQUIRES: concurrency

// rdar://106849189 move-only types should be supported in freestanding mode
// UNSUPPORTED: freestanding

// FIXME: rdar://107112715 test failing on iOS simulator, investigating
// UNSUPPORTED: OS=ios

// Such type may be encountered since Swift 5.5 (5.1 backdeployed) if someone implemented the
// not documented, but public Executor types back then already.
//
// We keep support for them, but also log a deprecation warning that they should move to the new signature.
@available(SwiftStdlib 5.1, *)
final class OldExecutor: SerialExecutor {
func enqueue(_ job: UnownedJob) {} // expected-warning{{'Executor.enqueue(UnownedJob)' is deprecated as a protocol requirement; conform type 'OldExecutor' to 'Executor' by implementing 'func enqueue(ExecutorJob)' instead}}

Expand All @@ -23,6 +21,7 @@ final class OldExecutor: SerialExecutor {
/// we call into the "old one"; so the Owned version is not used in such impl.
///
/// That's why we do log the deprecation warning, people should use the move-only version.
@available(SwiftStdlib 5.9, *)
final class BothExecutor: SerialExecutor {
func enqueue(_ job: UnownedJob) {} // expected-warning{{'Executor.enqueue(UnownedJob)' is deprecated as a protocol requirement; conform type 'BothExecutor' to 'Executor' by implementing 'func enqueue(ExecutorJob)' instead}}

Expand Down Expand Up @@ -52,6 +51,7 @@ final class TripleExecutor: SerialExecutor {
/// we manually detect and emit an error if neither of them is implemented.
///
/// We do so because we implement them recursively, so one of them must be implemented basically.
@available(SwiftStdlib 5.9, *)
final class NoneExecutor: SerialExecutor { // expected-error{{type 'NoneExecutor' does not conform to protocol 'Executor'}}

func asUnownedSerialExecutor() -> UnownedSerialExecutor {
Expand All @@ -71,6 +71,7 @@ final class StillDeprecated: SerialExecutor {
}

/// Just implementing the new signature causes no warnings, good.
@available(SwiftStdlib 5.9, *)
final class NewExecutor: SerialExecutor {
func enqueue(_ job: consuming ExecutorJob) {} // no warnings

Expand Down