[CSSyntaticElement] Canonicalize type before collecting "in scope" va… #65071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have an idea for a test. |
…riables Follow-up to swiftlang#65048 `getDesugaredType` unwraps sugar types that appear in sequence, to remove sugar from nested positions we need to get a canonical type. Thanks to @slavapestov for pointing it out.
xedin
force-pushed
the
rdar-107835060-followup
branch
from
19fc665 to
976c0b1
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Just to be clear this has never worked before. |
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
Author
|
@swift-ci please test Linux platform |
2 similar comments
Contributor
Author
|
@swift-ci please test Linux platform |
Contributor
Author
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…riables
Follow-up to #65048
getDesugaredTypeunwraps sugar types that appear in sequence,to remove sugar from nested positions we need to get a canonical type.
Thanks to @slavapestov for pointing it out.