Skip to content

Conversation

@ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 10, 2023

Description: Unblock tests which we had disabled because of the moveonly types not working in all configs previously: rdar://107050387. The fixes were done a6d2299 & df35da4 and therefore we should enable the tests again.
Risk: Low, enables tests
Review by: @DougGregor, @kavon who fixed the underlying moveonly issue
Testing: CI testing
Original PR: #65039
Radar: rdar://107112715

@ktoso ktoso requested a review from a team as a code owner April 10, 2023 10:28
@ktoso ktoso changed the title [Concurrency] Unlock executor tests on iOS again, moveonly issue was … 🍒[5.9][Concurrency] Unlock executor tests on iOS again, moveonly issue was … Apr 10, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please test macos

@kavon
Copy link
Member

kavon commented Apr 11, 2023

merging since it's purely a test-renablement change.

@kavon kavon merged commit 347123c into swiftlang:release/5.9 Apr 11, 2023
@ktoso ktoso deleted the pick-wip-unblock-ios-tests-moveonly-was-fixed branch April 11, 2023 02:02
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants