🍒[cxx-interop] Make sure interop does not trigger TBD validation errors #65007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
egorzhdan
changed the title
Contributor
Author
|
@swift-ci please test macOS |
DougGregor
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This disables TBD validation when C++ interop is enabled, unless an explicit
-validate-tbd-against-ir=flag was passed. It works around the errors produced by TBD validation, which require further investigation.Scope: Only has an effect when experimental C++ interop is enabled.
Risk: Low: C++ interop is an experimental feature that is not used in production.
Testing: Adjusted existing LIT tests.
rdar://83405989 / #56458
(cherry picked from commit 8f58eaf)