Skip to content

Conversation

@ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 7, 2023

According to SE review, we want to not take over the Job name.

This attempts to first introduce a typealias, and then we could maybe remove Job entirely.

Looking for input if this strategy makes sense.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 7, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 7, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please clean test with toolchain and preset

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

ExecutorJob/Job need to be handled manually in the "only one of overloads can be implemented" because of how we provide default impls for both. Glad that the tests caught that nicely.

Added the special handling in tryDiagnoseExecutorConformance if we get to remove Job we can undo the last commit from here

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please smoke test

@ktoso ktoso changed the title rename Job type [Concurrency] Rename Job to ExecutorJob, ease transition with typealias Apr 10, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please clean smoke test macos

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

Renaming job sadly overlapped with adding a test which used job type in message... re-running with adjustment.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 11, 2023

Our good ol' random failure friend:

macos.swiftinterface:4:8: error: no such module 'Combine'
import Combine
^

@ktoso
Copy link
Contributor Author

ktoso commented Apr 11, 2023

@swift-ci please smoke test macos

@ktoso ktoso merged commit 80b9386 into swiftlang:main Apr 11, 2023
@ktoso ktoso deleted the wip-rename-job branch April 11, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant