Skip to content

Conversation

@ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 5, 2023

A few snippets wrongly spelled snippets as try await withThrowingTaskGroup { group in, but we require being explicit about the group type like this: try await withThrowingTaskGroup(of: Void.self) { group in

Reported in https://twitter.com/kuba_suder/status/1643368916914253826

rdar://111547369

@ktoso ktoso requested a review from amartini51 April 5, 2023 07:58
@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features documentation labels Apr 5, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Apr 5, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 5, 2023

@swift-ci please smoke test Linux
@swift-ci please smoke test Windows

@amartini51
Copy link
Member

@swift-ci Please smoke test Linux

@ktoso
Copy link
Contributor Author

ktoso commented Apr 10, 2023

Something weird with the conflicts here -- this was a docs only change; will fix

@ktoso ktoso force-pushed the wip-group-param-docs branch from e0f05b2 to dd3a9ff Compare April 12, 2023 04:28
[docs][Concurrency] Fix typo in method signature in code snippets of groups
@ktoso ktoso force-pushed the wip-group-param-docs branch from dd3a9ff to 6bfef94 Compare June 30, 2023 03:18
@ktoso ktoso requested a review from kavon as a code owner June 30, 2023 03:18
@ktoso
Copy link
Contributor Author

ktoso commented Jun 30, 2023

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 1bcd73c into swiftlang:main Jun 30, 2023
@ktoso ktoso deleted the wip-group-param-docs branch July 3, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

concurrency Feature: umbrella label for concurrency language features documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants