[5.9] Bundle macro plugin changes #64793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executable plugins crashed or somehow decided to exit, the compiler should relaunch the plugin executable before sending another message. (cherry picked from commit a49ab25)
* Argument to '-load-plugin-library' now must have a filename that's
'{libprefix}{modulename}.{sharedlibraryextension}'
* Load '-load-plugin-library' plugins are now lazily loaded in
'CompilerPluginLoadRequest'
* Remove ASTContext.LoadedSymbols cache because they are cached by
'ExternalMacroDefinitionRequest' anyway
* `-load-plugin-executable` format validation is now in
'ParseSearchPathArgs'
(cherry picked from commit d8c8574)
Set 'SWIFT_DUMP_PLUGIN_MESSAGING' env variable to enable it. (cherry picked from commit bd9af09)
And stop using '-dump-macro-expansions' (cherry picked from commit d5b8c84)
Make a single 'PluginRegistry' and share it between SwiftASTManager, IDEInspectionInstance, and CompileInstance. And inject the plugin registry to ASTContext right after 'CompilerInstance.setup()' That way, all sema-capable ASTContext in SourceKit share a single PluginRegistry. (cherry picked from commit a4d1fc6)
PluginRegistry is now shared between multiple ASTContext. ASTContext should track its loaded plugin library paths separately. (cherry picked from commit 59f744c)
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test macOS |
DougGregor
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #64407 #64555 #64610 #64655 into
release/5.9Explanation: A bundle of macro plugin related changes (1) Recovery after external plugin crash, (2) Load
-load-plugin-librarylazily (3) Add environment variable to dump external plugin messagagings (4) Use a single PluginRegistry in multiple ASTContexts. All changes are important to improve the compiler stability regarding macro executable plugins.Scope: Macro resolution and expansion
Risk: Mid. Macro executable plugin system is a new feature
Testing: Added regression test cases
Reviewer: Ben Barham (@bnbarham), Alex Hoppen (@ahoppen), Doug Gregor (@DougGregor)