[shims] ensure that _SwiftConcurrency has the same Swift interface re… #64705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gardless of whether C++ interop is enabled This ensures that a module built from Swift interface file (and as such interop is disabled), that references 'exit' (from _SwiftConcurrencyShims module) can resolve the module reference to 'exit' even when it's being imported when interop is enabled (and thus it loads a different underlying _SwiftConcurrencyShims).
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
etcwilde
approved these changes
Mar 29, 2023
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
Yeah, I think this makes sense. I'm not sure why I had it in the swift namespace before, though that shouldn't affect the symbol because it's a C symbol.
Contributor
Author
|
Yup, unfortunately it affects the way it's imported into Swift when C++ interop is enabled, so this fixed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gardless of whether C++ interop is enabled
This ensures that a module built from Swift interface file (and as such interop is disabled), that references 'exit' (from _SwiftConcurrencyShims module) can resolve the module reference to 'exit' even when it's being imported when interop is enabled (and thus it loads a different underlying _SwiftConcurrencyShims).