[CopyPropagation] Canonicalize copies of owned lexical values. #64637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CopyPropagation only canonicalizes defs that are "canonical", that is, the root of the copy_value tree. When that canonical def is lexical, however, the canonicalization respects deinit barriers. But copies of lexical values are not themselves lexical, so their lifetimes can be shortened without respect to deinit barriers. Here, immediate copies of lexical values are canonicalized before the lexical values themselves are. rdar://107197935
nate-chandler
force-pushed
the
copy-propagation/canonicalize-lexical-copies
branch
from
10a02d8 to
4f0d1da
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CopyPropagation only† canonicalizes defs that are "canonical", that is, the root of the copy_value tree. When that canonical def is lexical, however, the canonicalization respects deinit barriers. But copies of lexical values are not themselves lexical, so their lifetimes can be shortened without respect to deinit barriers.
Here, immediate copies of lexical values are canonicalized before the lexical values themselves are.
rdar://107197935