Revert "Add a verify-di-hole assertion to SILBuilder." #64584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no value in hiding this flag in release builds. I meant to remove SWIFT_ASSERT_ONLY_DECL in the previous commit.
nate-chandler
force-pushed
the
revert-64494-dihole-assertion
branch
from
7c0b28e to
4ea51cf
Compare
Contributor
Author
|
Building the release noassert configuration locally succeeds with the revert and fails without it. The benchmark bots seem to need a clean, but there's no "clean benchmark" trigger. |
Contributor
|
Thanks for taking care of the revert, I'll see if I can fix the underlying issue! |
Contributor
Author
|
@swift-ci please benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to have broken building the stdlib noasserts.
rdar://107146237