Revert 75dc69a81da07647bda2d1ccc3b82ce6e68b44a7 #64513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
requested review from
egorzhdan,
hborla,
hyp,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci please smoke test |
hyp
approved these changes
Mar 21, 2023
xedin
approved these changes
Mar 21, 2023
etcwilde
reviewed
Mar 22, 2023
| CxxRecordSemantics::evaluate(Evaluator &evaluator, | ||
| CxxRecordSemanticsDescriptor desc) const { | ||
| const auto *decl = desc.decl; | ||
| auto &clangSema = desc.ctx.getClangModuleLoader()->getClangSema(); |
Member
There was a problem hiding this comment.
Is this just for side-effects? I don't see it getting used.
Contributor
Author
There was a problem hiding this comment.
There are no side effects here. This line can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves #NNNNN, fix apple/llvm-project#MMMMM.