Tie Swift backtracing pieces together in build #64362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ties the runtime and stdlib backtracing pieces together. The `__swift_isThunkFunction` SPI is provided in the backtracing runtime, which is gated behind `SWIFT_ENABLE_BACKTRACING`. If that flag is turned off, the `Backtracing` part of the stdlib fails to build because the symbols are missing, causing a build failure. I've also added the explicit `option(SWIFT_ENABLE_BACKTRACING` option so that incremental re-runs of CMake get the flag added with a nice comment and a boolean value. The option is defaulted to OFF, though build-script is defaulting it to ON.
Member
Author
|
@swift-ci please test |
al45tair
approved these changes
Mar 14, 2023
compnerd
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ties the runtime and stdlib backtracing pieces together. The
__swift_isThunkFunctionSPI is provided in the backtracing runtime, which is gated behindSWIFT_ENABLE_BACKTRACING. If that flag is turned off, theBacktracingpart of the stdlib fails to build because the symbols are missing, causing a build failure.I've also added the explicit
option(SWIFT_ENABLE_BACKTRACINGoption so that incremental re-runs of CMake get the flag added with a nice comment and a boolean value. The option is defaulted to OFF, though build-script is defaulting it to ON.