Ensure autodiff code does not ignore getSingleTerminatorOperands return value
#64200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn value. Extend activity analysis to handle `try_apply` normal result properly.
Contributor
Author
|
Tagging @BradLarson |
Contributor
Author
|
@swift-ci please test |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
rxwei
approved these changes
Mar 8, 2023
| // an `Optional`-typed value. `switch_enum` instructions require | ||
| // special-case adjoint value propagation for the operand. | ||
| auto isSwitchEnumInstOnOptional = | ||
| if (bbArg->getSingleTerminatorOperands(incomingValues)) { |
Contributor
There was a problem hiding this comment.
Should we do an early return here to reduce nesting?
Contributor
Author
There was a problem hiding this comment.
It seems we'd need to eventually handle else case since it at least covers try_apply instruction among the others. The fix for activity calculation was pretty straightforward, but I will need to think how to proceed with adjoint propagation. I do not have a testcase for this right now, but hopefully @BradLarson will be able to distill some from their codebase.
For now we just do not silently generate incorrect code :)
Contributor
|
(A bit too busy to review this week – cheers!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend activity analysis to handle
try_applynormal result properly.