[Backtracing] Fix out-of-process async backtraces. #64178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
mikeash
approved these changes
Mar 7, 2023
Contributor
mikeash
left a comment
mikeash
left a comment
There was a problem hiding this comment.
swift-inspect knows how to get the current task of a remote thread (on Darwin, anyway) if you want to crib from that at some point. It's not pretty.
Contributor
Author
|
How odd. The macOS build failed to demangle some of the symbols. (There's some other problem that someone has introduced in the meantime that's broken PR testing also.) |
Contributor
Author
|
@swift-ci Please smoke test |
These weren't working correctly because I made the unwinder call `_swift_task_getCurrent()`, but of course when out-of-process, it calls that in `swift-backtrace`, which is wrong. Remove that for now. While I'm here, I also tweaked the formatting slightly, and I noticed that we were saying that all thunks were also system functions, which seemed unnecessary and odd. Plus there were a couple of extra system functions I added to make the async crash backtraces nicer in friendly mode. rdar://106363539
Contributor
Author
|
Ah, I wonder if the issue is that the macOS CI is running an older macOS that can't demangle async function names. That would make sense as it's clearly demangled the top frame correctly. |
al45tair
force-pushed
the
eng/PR-106363539
branch
from
58f2364 to
43375e7
Compare
The CI nodes currently run an older macOS version that can't demangle the async function names. So, to pass PR testing and CI, we'll need to turn demangling off for this test for now. No big deal. rdar://106363539
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These weren't working correctly because I made the unwinder call
_swift_task_getCurrent(), but of course when out-of-process, it calls that inswift-backtrace, which is wrong. Remove that for now.While I'm here, I also tweaked the formatting slightly, and I noticed that we were saying that all thunks were also system functions, which seemed unnecessary and odd.
Plus there were a couple of extra system functions I added to make the async crash backtraces nicer in friendly mode.
rdar://106363539