[Remote Test] Fix remote-run to process environment variables. #64175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`remote-run` should look in the environment for input/output paths as well as considering command line arguments. With this change, `test/Runtime/Paths.cpp` should work for remote testing and device testing. rdar://106294557
Contributor
Author
|
@swift-ci Please smoke test |
compnerd
approved these changes
Mar 7, 2023
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Would be nice to get a second pair of eyes on this as well. The shuffling around of the code made this a bit of a challenge to review very carefully.
mikeash
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote-runshould look in the environment for input/output paths as well as considering command line arguments.With this change,
test/Runtime/Paths.cppshould work for remote testing and device testing.rdar://106294557