[Runtime] Avoid referring to enum _dyld_section_location_kind. #64042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci test |
mikeash
force-pushed
the
fix-dyld-section-enums
branch
from
4fe16b8 to
e4e5af3
Compare
Contributor
Author
|
@swift-ci please test and merge |
1 similar comment
Contributor
Author
|
@swift-ci please test and merge |
Contributor
Author
|
@swift-ci please test macos platform |
mikeash
force-pushed
the
fix-dyld-section-enums
branch
from
e4e5af3 to
66e2416
Compare
Contributor
Author
|
@swift-ci please test and merge |
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Mar 28, 2023
This reverts commit a4c572f, to be added back in after swiftlang#64042.
If the SDK has dyld_priv.h but doesn't have enum _dyld_section_location_kind, we can't use enum _dyld_section_location_kind and it's hard to detect that. Instead, just use `int`, and use #defines for the values.
mikeash
force-pushed
the
fix-dyld-section-enums
branch
from
66e2416 to
f7e3256
Compare
Contributor
Author
|
@swift-ci please test and merge |
etcwilde
pushed a commit
to etcwilde/swift
that referenced
this pull request
Apr 19, 2023
This reverts commit a4c572f, to be added back in after swiftlang#64042.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the SDK has dyld_priv.h but doesn't have enum _dyld_section_location_kind, we can't use enum _dyld_section_location_kind and it's hard to detect that. Instead, just use
int, and use #defines for the values.