[NameLookup] Collect implicit opaque GenericParams #64037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
reviewed
Mar 2, 2023
angela-laar
force-pushed
the
fix-generic-type-paramters-implicit-some
branch
from
efcd422 to
41392db
Compare
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
reviewed
Mar 8, 2023
Plain protocols with generic type paramters should be collected as opaque types.
angela-laar
force-pushed
the
fix-generic-type-paramters-implicit-some
branch
from
41392db to
ac00a8c
Compare
Contributor
Author
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
fix-generic-type-paramters-implicit-some
branch
from
6f230b0 to
68e1de4
Compare
angela-laar
force-pushed
the
fix-generic-type-paramters-implicit-some
branch
from
68e1de4 to
3a20ff0
Compare
Contributor
Author
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
fix-generic-type-paramters-implicit-some
branch
from
71c42a6 to
c3eb22a
Compare
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain protocols with generic type parameters should be collected as opaque types i.e.
Collection<T>Fixes: rdar://101405496