[CSSimplify] Detect and diagnose generic argument mismatches individually #64036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
This locator is going to be used as a "parent" element for "generic argument" elements.
Contributor
Author
|
@swift-ci please test |
…ally Generic arguments types are not always resolved enough to enable aggregated mismatch fixes, which means that the solver should be able to handle standalone generic argument matching constraints and create a fix per mismatch location to coalesce them during diagnostics. Resolves: rdar://106054263
Contributor
Author
|
@swift-ci please test |
hborla
reviewed
Mar 5, 2023
Contributor
Author
|
@swift-ci please test Linux platform |
hborla
approved these changes
Mar 5, 2023
Contributor
Author
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic arguments types are not always resolved enough to enable
aggregated mismatch fixes, which means that the solver should be
able to handle standalone generic argument matching constraints
and create a fix per mismatch location to coalesce them during
diagnostics.
Resolves: rdar://106054263