[IRGen] Lowered de/alloc_pack. #63513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
requested review from
hborla,
slavapestov and
xedin
as code owners
nate-chandler
force-pushed
the
variadic-generics/irgen/alloc_pack
branch
from
fb85d9d to
18dd471
Compare
Contributor
Author
|
@swift-ci please test |
Made TypeBase's implementation dispatch to the implementation specific to SILPackType.
rjmccall
reviewed
Feb 9, 2023
Contributor
rjmccall
left a comment
rjmccall
left a comment
There was a problem hiding this comment.
LGTM other than the test thing
nate-chandler
force-pushed
the
variadic-generics/irgen/alloc_pack
branch
from
18dd471 to
2118ad3
Compare
nate-chandler
force-pushed
the
variadic-generics/irgen/alloc_pack
branch
from
2118ad3 to
da5b5c1
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowered to dynamic or static allocation of
getPackElementSize() * count.