[gardening] change an ambiguous variable name #63237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lowercase-l trips some python lint configurations
|
@swift-ci please smoke test |
Azoy
approved these changes
Jan 26, 2023
lorentey
approved these changes
Jan 27, 2023
edymtt
pushed a commit
to edymtt/swift
that referenced
this pull request
May 23, 2023
- lowercase-l trips some python lint configurations (cherry picked from commit 36d230e, swiftlang#63237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variable name that consists of the single lowercase letter L trips some python lint configurations. This causes local test runs to fail for an uninteresting reason. This commit changes the offending variable name to a single underscore, which is apparently better.