Sema: Lift restriction requiring decls with @_backDeploy to have explicit availability
#62876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
approved these changes
Jan 6, 2023
Contributor
nkcsgexi
left a comment
nkcsgexi
left a comment
There was a problem hiding this comment.
Thanks! Makes sense to me.
…explicit availability. Resolves rdar://103880356
tshortli
force-pushed
the
remove-back-deploy-available-attr-requirement
branch
from
640c9b0 to
8e46b76
Compare
Contributor
Author
|
@swift-ci please test |
This was referenced Jan 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Evolution has concluded that it is inappropriate to require decls with
@_backDeployto also have explicit availability. Lift the restriction and assume declarations with no explicit availability are back deployed as far as possible.Lifting a simultaneous attribute restriction sounds like it should be an easy task, but that was not the case here. The diagnostics for availability conflicts with the back deployment
before:version were greatly simplified by the assumption that an explicit@availableattribute would be present. With the removal of the restriction the implementation of the diagnostics had to be enhanced to look for both inherited availability and unavailability.Additionally, this PR fixes a bug that would have caused the wrong
@_backDeployattribute to be used when attributes for bothiOSandmacCatalystare present.Resolves rdar://103880356