[Runtime] Temporarily update attribute ordering #62667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-15 requires `extern "C"` to be the first attribute and does not allow mixing GNU attributes and standard attributes. Temporarily split and re-order attributes to prevent compilation errors. Avoid updating the public stdlib here (`Visibility.h`) and instead add the definitions to `Config.h`, which all impacted headers and up including. This should be removed once Swift uses at least stable/20221013, which has https://reviews.llvm.org/D137979 and would thus allow us to just move `SWIFT_RUNTIME_EXPORT` to be the first attribute. Resolves swiftlang#61468.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
#62497 doesn't work on |
compnerd
approved these changes
Dec 18, 2022
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Thanks, this seems like a good compromise for the 5.8 release.
Contributor
Author
|
@eeckstein this will have rebranch merge conflicts from this I imagine. I'll fix those + put up the separate fix tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-15 requires
extern "C"to be the first attribute and does not allow mixing GNU attributes and standard attributes. Temporarily split and re-order attributes to prevent compilation errors. Avoid updating the public stdlib here (Visibility.h) and instead add the definitions toConfig.h, which all impacted headers and up including.This should be removed once Swift uses at least stable/20221013, which has https://reviews.llvm.org/D137979 and would thus allow us to just move
SWIFT_RUNTIME_EXPORTto be the first attribute.Resolves #61468.