[Reflection] Make TypeRefVisitor robust to NULL typerefs and unknown kinds. #62483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kinds. These shouldn't happen, but we may encounter bad data which results in a NULL typeref pointer, or a bogus kind value. rdar://103111816 rdar://103105744
Contributor
Author
|
@swift-ci please test |
al45tair
approved these changes
Dec 12, 2022
Contributor
al45tair
left a comment
al45tair
left a comment
There was a problem hiding this comment.
Do we want to log a message when these conditions occur?
Contributor
Author
|
Discussed offline, but repeating here for posterity: this is a somewhat-expected condition (because we'll inevitably encounter bad data in the target process) so we don't want to clutter up the program's output with non-fatal error messages. Ideally we'd return an error to the caller, but that's a much more extensive change to consider later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These shouldn't happen, but we may encounter bad data which results in a NULL typeref pointer, or a bogus kind value.
rdar://103111816 rdar://103105744