Skip to content

[Compile Time Constant Extraction] Add extension extraction support #62465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

[Compile Time Constant Extraction] Add extension extraction support #62465

merged 1 commit into from
Dec 9, 2022

Conversation

@jPaolantonio
Copy link
Contributor

@jPaolantonio jPaolantonio commented Dec 8, 2022 •
edited
Loading

Add extraction for computed variables in extensions.

@jPaolantonio
Copy link
Contributor Author

jPaolantonio commented Dec 8, 2022

@swift-ci test

artemcm
artemcm approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks @jPaolantonio !

quinntaylor
quinntaylor approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@quinntaylor quinntaylor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! For completeness, it might also be good to add more properties declared in the extension that will resolve to valueKind other than Runtime.

@jPaolantonio
Copy link
Contributor Author

jPaolantonio commented Dec 8, 2022

Looks great! For completeness, it might also be good to add more properties declared in the extension that will resolve to valueKind other than Runtime.

I agree. Ideally, that Runtime should also be statically extractable. We do not currently support extracting out InitValues from computed properties. Will fix.

@jPaolantonio jPaolantonio merged commit 186e55f into swiftlang:main Dec 9, 2022
@jPaolantonio jPaolantonio deleted the const-extract-extension-computed-vars branch December 9, 2022 13:13
@jPaolantonio jPaolantonio mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quinntaylor quinntaylor quinntaylor approved these changes

@artemcm artemcm artemcm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jPaolantonio @quinntaylor @artemcm