[Compile Time Constant Extraction] Refactor to support recursion. #62461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract `extractCompileTimeValue()` function to recursively handle `CompileTimeValue` hierarchies. Inline `extractLiteralOutput()` to only be used from the one remaining call site. Refactor `ExprKind::Call` handling to reduce branching for args with a `DefaultArgumentExpr`.
Contributor
Author
|
@swift-ci test |
jPaolantonio
approved these changes
Dec 8, 2022
| if (originalInit) { | ||
| auto literalOutput = extractLiteralOutput(originalInit); | ||
| static std::shared_ptr<CompileTimeValue> extractCompileTimeValue(Expr *expr) { | ||
| if (expr) { |
Contributor
There was a problem hiding this comment.
Were you seeing nullptrs passed into this function?
Contributor
Author
There was a problem hiding this comment.
This is more of a precautionary construct, to avoid bad dereferences if nullptr were to get passed in, now or in the future.
artemcm
approved these changes
Dec 8, 2022
Contributor
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
extractCompileTimeValue()function to recursively handleCompileTimeValuehierarchies.Inline
extractLiteralOutput()to only be used from the one remaining call site.Refactor
ExprKind::Callhandling to reduce branching for args with aDefaultArgumentExpr.