[IDE] Allow typeCheckASTNodeAtLoc to type check declarations #62366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
We need the ability to type check declarations when entering using `typeCheckASTNodeAtLoc` for solver-based cursor info. This causes more context to be type checked for code completion and breaks some type completion after dot if the base type is not fully qualified because the type checker will mark `TypeRepr` as invalid. But since we don’t actually need to run the type checker for type member completion, we can just not call `typeCheckContextAt` for `TypeIdentifierWithDot` completions.
ahoppen
changed the title
ahoppen
force-pushed
the
ahoppen/solver-based-cursor-info-prep-pt-3
branch
from
d87c3d6 to
fe228a4
Compare
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
@swift-ci Please SourceKit stress test |
Member
Author
|
Stress tester failures are all #57045 and shouldn’t stop merging of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to type check declarations when entering using
typeCheckASTNodeAtLocfor solver-based cursor info.This causes more context to be type checked for code completion and breaks some type completion after dot if the base type is not fully qualified because the type checker will mark
TypeRepras invalid. But since we don’t actually need to run the type checker for type member completion, we can just not calltypeCheckContextAtforTypeIdentifierWithDotcompletions.