Fix CLion getting started, swift-syntax is also required now #62252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also include the swift-syntax path, otherwise CMake import in CLion will fail.
egorzhdan
approved these changes
Nov 28, 2022
Contributor
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
LGTM!
I wonder if the CMake scripts could assume that the dependency projects are located in the same directory as Swift itself by default, that would make it more convenient for people to build Swift with CMake directly.
Contributor
Author
|
Yeah that sounds like a safe thing to assume tbh. I'll do a follow up ticket for it |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
Follow up here: #62291 |
Contributor
Author
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include the swift-syntax path, otherwise CMake import in CLion will fail.