build-script-impl: remove CMark cases as unused #62234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
MaxDesiatov
force-pushed
the
maxd/cmark-build-cleanup
branch
from
e83e889 to
5849c69
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MaxDesiatov
force-pushed
the
maxd/cmark-build-cleanup
branch
from
5849c69 to
a427721
Compare
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
CMark was converted from a `build-script-impl` product to `build-script` product in #37102. After that change remaining mentions of CMark in `build-script-impl` were unused and can be removed.
MaxDesiatov
force-pushed
the
maxd/cmark-build-cleanup
branch
from
8a7f362 to
4ee657b
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please build toolchain |
Contributor
Author
|
@swift-ci please smoke test Linux |
MaxDesiatov
requested review from
compnerd,
drexin,
edymtt,
gottesmm and
shahmishal
Contributor
Author
|
@swift-ci please smoke test macOS |
shahmishal
approved these changes
Nov 29, 2022
gottesmm
approved these changes
Nov 29, 2022
Contributor
gottesmm
left a comment
gottesmm
left a comment
There was a problem hiding this comment.
LGTM. Thanks for eliminating dead code.
compnerd
approved these changes
Nov 30, 2022
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
It is great to see this get reduced!
Contributor
Author
|
Verified that this builds successfully in different configurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small part of #42859.
CMark was converted from a
build-script-implproduct tobuild-scriptproduct in #37102. After that change, some of the remaining mentions of CMark inbuild-script-implwere unused and can be removed.