[Interop] [SwiftToCxx] Modify the swift::Error Dynamic Cast to return a Swift::Optional #62197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
requested review from
egorzhdan,
hyp and
zoecarver
as code owners
Contributor
|
@swift-ci please test |
…xInteroperability.h` to Swift::Error in `_SwiftStdlibCxxOverlay.h`
…cast error returns a Swift::Optional
Robertorosmaninho
force-pushed
the
cxx-interop/DynamicCastToSwiftErrorWithOptional
branch
from
bfc8655 to
fdc1d0c
Compare
Contributor
|
@swift-ci please test |
Contributor
|
@swift-ci please test source compatibility |
Robertorosmaninho
deleted the
cxx-interop/DynamicCastToSwiftErrorWithOptional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Swift::Optionalon the dynamic casting ofswift::Error;swift::Errorclass is defined;NaiveException.