Correct effective context translation for NS_OPTIONS anon C++ enums attempt 2 #62172
Conversation
|
@swift-ci please smoke test |
NuriAmari
changed the title
Please run the full test suite instead of just |
Yes I will, I'm just trying to run the macOs smoke tests repeatedly since I'm unable to reproduce the failure that caused the revert locally, and it seems to have passed in many many CI runs prior to the revert. https://ci.swift.org/job/swift-PR-macos-smoke-test/4317/. Did this break PR break something a full run of |
|
First smoke test: |
|
@swift-ci please test |
Prior to this patch, SwiftLookupTable::translateDeclToContext relied
on the `TypedefNameDeclOrQualifier` field of an anonymous tag decl to
create a name for entry representing an anonymous tag in the lookup
table. This field is not always populated by Clang, it is often
populated only for the purposes of generating a linkage name when the
type is introduced via typedef as follows:
```
typedef enum { option1, option2} MyAnonEnum;
```
The field is not populated for anonymous enums introduced by NS_OPTIONS
with cxx interop enabled. This patch adds a fallback check in
`translateDeclToContext` that if the field is empty, check if the enum
is backed by a typedef that is unavailable in Swift. If that is the
case, use that name for the lookup table entry.
NuriAmari
force-pushed
the
ns-option-lookup-table-warning-attempt-2
branch
from
03bcf18 to
5f5bebf
Compare
|
@swift-ci please test |
| @@ -0,0 +1,11 @@ | |||
| // RUN: %empty-directory(%t/cache) | |||
There was a problem hiding this comment.
@hyp I think @drodriguez found the issue, these two tests were sharing a module cache and emptying it at the start of the test. If these tests are run concurrently you get weird flaky failures. I've changed %T -> %t to make sure the module cache directories are distinct.
|
@swift-ci please test source compatibility |
2 participants
Second attempt at: 62058