[gardening] Fix shellcheck warnings in recently introduced file find-overlay-deps-closure.sh #6210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
erg
reviewed
Dec 11, 2016
utils/find-overlay-deps-closure.sh
Outdated
Contributor
There was a problem hiding this comment.
This makes it take twice as long.
Put this inside the line 48 loop and see how it calls the regex on \ lines as well.
echo "line: $line" >&2 # line 49
Contributor
|
Looks good if you fix the speed regression. Thanks! |
…overlay-deps-closure.sh
Contributor
Author
|
@erg Fixed! :-) |
Contributor
Author
|
@swift-ci please smoke test and merge |
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @erg - please review :-)