Skip to content

[Distributed] fix deprecation warning in LocalTesting #61415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

[Distributed] fix deprecation warning in LocalTesting #61415

merged 2 commits into from
Oct 24, 2022

Conversation

@MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Oct 3, 2022

This change fixes following warnings:

LocalTestingDistributedActorSystem.swift:30:30: warning: 'LocalTestingActorAddress' is deprecated: renamed to 'LocalTestingActorID'
  public typealias ActorID = LocalTestingActorAddress
                             ^
LocalTestingDistributedActorSystem.swift:30:30: note: use 'LocalTestingActorID' instead
  public typealias ActorID = LocalTestingActorAddress
                             ^~~~~~~~~~~~~~~~~~~~~~~~
                             LocalTestingActorID
LocalTestingDistributedActorSystem.swift:117:29: warning: 'LocalTestingActorAddress' is deprecated: renamed to 'LocalTestingActorID'
    mutating func next() -> LocalTestingActorAddress {
                            ^
LocalTestingDistributedActorSystem.swift:117:29: note: use 'LocalTestingActorID' instead
    mutating func next() -> LocalTestingActorAddress {
                            ^~~~~~~~~~~~~~~~~~~~~~~~
                            LocalTestingActorID

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Oct 3, 2022

@swift-ci please smoke test

@MaxDesiatov MaxDesiatov changed the title Distributed: fix deprecation warning in LocalTestingDistributedActorSystem Distributed: fix deprecation warning in LocalTesting Oct 3, 2022
@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Oct 3, 2022

@swift-ci please test Windows platform

@MaxDesiatov MaxDesiatov marked this pull request as ready for review October 3, 2022 17:22
@MaxDesiatov MaxDesiatov requested a review from ktoso October 3, 2022 17:22
@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Oct 3, 2022

@swift-ci please smoke test

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Oct 4, 2022

@swift-ci please smoke test

@ktoso ktoso changed the title Distributed: fix deprecation warning in LocalTesting [Distributed] fix deprecation warning in LocalTesting Oct 24, 2022
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Oct 24, 2022
ktoso
ktoso approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you :-)

@ktoso ktoso merged commit ffc6152 into main Oct 24, 2022
@ktoso ktoso deleted the maxd/fix-distributed-deprecation branch October 24, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktoso ktoso ktoso approved these changes

Assignees

No one assigned

Labels

distributed Feature → concurrency: distributed actor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxDesiatov @ktoso