[Build] Determine the early SwiftSyntax build directory in build-script-impl #61211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please test source compatibility |
…pt-impl Cross-compilation of the host depends on iteration over all of the host architectures within build-script-impl itself, so the computation of the build directory must occur in build-script-impl. Sink it down there to fix builds for multiple host architectures.
DougGregor
force-pushed
the
swiftsyntax-build-multi-host-archs
branch
from
ea3d50b to
b037a7c
Compare
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
The @swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-compilation of the host depends on iteration over all of the host architectures within build-script-impl itself, so the computation of the build directory must occur in build-script-impl. Sink it down there to fix builds for multiple host architectures.
Addresses rdar://100182363, wherein I broke all of the builds involving multiple cross-compiled hosts.