Skip to content

[5.7] Updating Swift tests to remove outdated tests and use more current calls #61196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[5.7] Updating Swift tests to remove outdated tests and use more current calls #61196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
292c946
Updating Swift tests to remove outdated tests and use more current ca…
Sep 16, 2022
32ae372
Update test/Interpreter/SDK/Foundation_NSRect.swift
shahmishal Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions test/Interpreter/SDK/FoundationDiagnostics.swift
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion test/Interpreter/SDK/Foundation_NSRect.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// iOS doesn't have NSRect. iOS and OS X CGRect is tested elsewhere.
// REQUIRES: OS=macosx

import Foundation
import CoreImage

_ = JSONDecoder()

func printRect(_ r: NSRect) {
// FIXME: Constraint checker takes too long to typecheck this as an
Expand Down
10 changes: 0 additions & 10 deletions test/Interpreter/SDK/Quartz_without_Foundation.swift
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions test/Interpreter/SDK/objc_implicit_inner_pointer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
// REQUIRES: executable_test
// REQUIRES: objc_interop

import Foundation

_ = JSONDecoder()

do {
// The lifetime of Foo() currently gets extended using autorelease.
autoreleasepool {
Expand Down
2 changes: 2 additions & 0 deletions test/Interpreter/SDK/objc_inner_pointer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
// REQUIRES: objc_interop

import Foundation

_ = JSONDecoder()

class Canary: NSObject {
deinit {
Expand Down
2 changes: 2 additions & 0 deletions test/Interpreter/SDK/objc_unowned.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

import Foundation

_ = JSONDecoder()

let x = NSObject()
unowned let y = x

Expand Down
7 changes: 4 additions & 3 deletions test/stdlib/NSStringAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,10 @@ NSStringAPIs.test("init(contentsOf:usedEncoding:error:)") {
}

NSStringAPIs.test("init(cString_:encoding:)") {
expectEqual("foo, a basmati bar!",
String(cString:
"foo, a basmati bar!", encoding: String.defaultCStringEncoding))
"foo, a basmati bar!".withCString {
expectEqual("foo, a basmati bar!",
String(cString: $0, encoding: String.defaultCStringEncoding))
}
}

NSStringAPIs.test("init(utf8String:)") {
Expand Down
1 change: 1 addition & 0 deletions validation-test/compiler_crashers_2_fixed/rdar81590807.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func run(on object: PFXObject) async throws {

@main struct Main {
static func main() async throws {
_ = JSONDecoder()
let object = PFXObject()
try await run(on: object)
}
Expand Down