SILGen: Function availability for linkage should use @_backDeploy OS version if present
#61169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S version if present. When computing the availability of a `SILFunction` for linkage the OS version specified in the `@_backDeploy` attribute should be preferred over the version in the `@available` attribute. This ensures that the corresponding symbol is weakly linked when deploying to older OSes than the back deploy "before" version. Resolves rdar://99962885
Contributor
Author
|
@swift-ci please smoke test |
artemcm
approved these changes
Sep 17, 2022
Contributor
artemcm
left a comment
artemcm
left a comment
There was a problem hiding this comment.
Ah, neat.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the availability of a
SILFunctionfor linkage the OS version specified in the@_backDeployattribute should be preferred over the version in the@availableattribute. This ensures that the corresponding symbol is weakly linked when deploying to older OSes than the back deploy "before" version.Resolves rdar://99962885