[Sema] Report conflicting uses of @_spiOnly with other import modifiers
#61058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that an
@_spiOnlyattribute isn't used with@_implementationOnlyor@_exportedon the same import statement or in the same source file. This check is partially integrated with the existing check for@_implementationOnlyconsistency. This could be integrated further once we have a per-file implementation-only import alternative, for now the differences between@_implementationOnlyand@_spiOnlymakes it a bit messy.For clarification, here's what we check:
@_spiOnly,@_implementationOnlyand@_exported.@_spiOnlyimports of the same target within one source file.@_implementationOnlyimports of the same target within a module.Follows the integration with API checks from #61023. This should complete the main feature, but of course, further tweaks will likely be needed.