[Freestanding] Disable checked continuations. #60790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the task-to-thread model, there are no threading mechanisms by which work could be offloaded onto another thread. As such, callback based asynchronous APIs which are not Swift async do not make sense. rdar://99047747
Contributor
Author
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
theblixguy
reviewed
Aug 26, 2022
| body(CheckedContinuation(continuation: $0, function: function)) | ||
| } | ||
| } | ||
| #else |
Collaborator
There was a problem hiding this comment.
Have you considered using SE-0367? I think using that you can conditionally add the available attribute on the main declaration and avoid having to duplicate it.
So for example just above main declaration public struct CheckedContinuation, you can add:
#if SWIFT_STDLIB_TASK_TO_THREAD_MODEL_CONCURRENCY
@available(*, unavailable, message: "Unavailable in task-to-thread concurrency model")
#endif
Contributor
Author
There was a problem hiding this comment.
The implementation also changes.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the task-to-thread model, there are no threading mechanisms by which work could be offloaded onto another thread. As such, callback based asynchronous APIs which are not Swift async do not make sense.
rdar://99047747