Fixing /IDE/crashers/016-swift-mangle-mangler-mangleidentifier.swift #6079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test and merge |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test and merge |
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
reviewed
Dec 6, 2016
|
|
||
| // Avoid mangling nameless entity. This may happen in erroneous code as code | ||
| // completion. | ||
| if (!decl->hasName()) |
Contributor
There was a problem hiding this comment.
Why does it not have a name? Would it be better to ensure a name is always set? Or maybe we shouldn't be trying to mangle the entity in the first place? Or perhaps we should fix the mangler to just not allow this?
Contributor
Author
There was a problem hiding this comment.
This is to improve the mangler to allow nameless entities, in this test case let:{. As far as i know, we don't have a default name to set on the var decl lead by let, so to fix mangler to be more forgiving is a reasonable solution.
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/29308878
rdar://problem/28387632