Formalize Labeled Syntax #60396
Formalize Labeled Syntax #60396
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
1 similar comment
|
@swift-ci please smoke test macOS |
This represents labeled statements as an explicit kind of statement and removes the Labeled trait. Any kind of statement is allowed to be labeled in the tree, but we specifically diagnose the syntax elements that aren't allowed to have labels. This homogenizes the way clients deal with statement labels and also makes parser recovery quite a bit easier in the case where we have a label but no actual statement following it.
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test |
| # while-stmt -> label? ':'? 'while' condition-list code-block ';'? | ||
| Node('WhileStmt', kind='Stmt', | ||
| traits=['WithCodeBlock', 'Labeled'], | ||
| traits=['WithCodeBlock'], |
There was a problem hiding this comment.
Should the specifications be updated as well?
There was a problem hiding this comment.
What specification are you referring to? The "grammar" is still correct - we don't necessarily want the notion of a "labeled statement" in the formal grammar since not all the statements support labels!
There was a problem hiding this comment.
I was referring to the comment in the above preview (ditto the other nodes you modified), not the actual grammar in the language reference, although, curiously, it does have a notion of a labeled statement too.
This represents labeled statements as an explicit kind of statement and removes the Labeled trait. Any kind of statement is allowed to be labeled in the tree, but we specifically diagnose the syntax elements that aren't allowed to have labels. This homogenizes the way clients deal with statement labels and also makes parser recovery quite a bit easier in the case where we have a label but no actual statement following it.