Fix errors and warnings building swift/serialization on Windows with MSVC #6024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Dec 2, 2016
Contributor
There was a problem hiding this comment.
MSVC really doesn't support sizeof(value) in a static_assert?
Let's call it ModuleBits, I guess…
Contributor
Author
There was a problem hiding this comment.
It doesn't seem to support sizeof(value) well in many places. It's always happy with sizeof(TypeName) though...
I've renamed the struct as you suggested.
jrose-apple
approved these changes
Dec 2, 2016
Contributor
|
@swift-ci Please smoke test and merge |
Contributor
Author
|
Strange CI error? looks like tests passed but ci couldn't merge |
hughbe
commented
Dec 15, 2016
| class Serialized { | ||
| private: | ||
| using RawBitOffset = decltype(DeclTypeCursor.GetCurrentBitNo()); | ||
| using RawBitOffset = uint64_t; |
Contributor
Author
There was a problem hiding this comment.
Very strange bug - only occurs with nested generic classes - https://connect.microsoft.com/VisualStudio/feedback/details/3116520
hughbe
commented
Dec 16, 2016
| unsigned : 0; | ||
| } Bits = {}; | ||
| static_assert(sizeof(Bits) <= 8, "The bit set should be small"); | ||
| static_assert(sizeof(ModuleBits) <= 8, "The bit set should be small"); |
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decltype()when its used as a return type in an operator. Fixed by replacing thedecltypewithuint64_tsizeof(instance). Fixed by usingsizeof(structType)instead