Emit Sendable diagnostics in actor-like deinits only in 'complete' checking mode #59452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
DougGregor
approved these changes
Jun 15, 2022
…ecking mode The flow-isolation pass was not respecting the new strict-concurrency checking mode. Since the Sendable diagnostics in these deinits are very noisy, I'm moving them to only be emitted in 'complete' mode. The reason why they're so noisy is that any class that inherits from a `@MainActor`-constrained class will have these diagnostics emitted when trying to access its own `@MainActor`-isolated members. This is needed, even during the `deinit`, because multiple instances of a `@MainActor`-isolated class might have stored properties that refer to the same state. This change specifically avoids emitting these diagnostics even in 'targeted' mode because I'd like to take more time to reconsider the ergonomics of these deinits. resolves rdar://94699928
kavon
force-pushed
the
silence-deinit-warnings
branch
from
8749d6e to
3211bd8
Compare
Member
Author
|
@swift-ci please smoke test and merge |
1 similar comment
Member
Author
|
@swift-ci please smoke test and merge |
beccadax
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow-isolation pass was not respecting the new strict-concurrency checking mode.
Since the Sendable diagnostics in these deinits are very noisy, I'm moving them to only
be emitted in 'complete' mode. The reason why they're so noisy is that any class that
inherits from a
@MainActor-constrained class will have these diagnostics emitted whentrying to access its own
@MainActor-isolated members.This is needed, even during the
deinit, because multiple instances of a@MainActor-isolatedclass might have stored properties that refer to the same state.
This change specifically avoids emitting these diagnostics even in 'targeted' mode because
I'd like to take more time to reconsider the ergonomics of these deinits.
resolves rdar://94699928