Skip to content

Handle ParamDecls and VarDecls in Argument Matching Diagnostics #59090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022
Merged

Handle ParamDecls and VarDecls in Argument Matching Diagnostics #59090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/Sema/CSSimplify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4896,9 +4896,13 @@ bool ConstraintSystem::repairFailures(
if (!(overload && overload->choice.isDecl()))
return true;

if (!getParameterList(overload->choice.getDecl())
->get(applyLoc->getParamIdx())
->getTypeOfDefaultExpr())
// Ignore decls that don't have meaningful parameter lists - this
// matches variables and parameters with function types.
auto *paramList = getParameterList(overload->choice.getDecl());
if (!paramList)
return true;

if (!paramList->get(applyLoc->getParamIdx())->getTypeOfDefaultExpr())
return true;
}
}
Expand Down
7 changes: 7 additions & 0 deletions test/Constraints/argument_matching.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,3 +1782,10 @@ func testExtraTrailingClosure() {
func qux(x: () -> Void, y: () -> Void, z: () -> Void) {} // expected-note {{'qux(x:y:z:)' declared here}}
qux() {} m: {} y: {} n: {} z: {} o: {} // expected-error@:6 {{extra trailing closures at positions #2, #4, #6 in call}}
}

// rdar://93922410 - argument-to-parameter doesn't handle applies of ParamDecls
func rdar93922410(_ completion: (Int?) -> Void) { // expected-note {{'completion' declared here}}
_ = {
return completion() // expected-error {{missing argument for parameter #1 in call}}
}
}